Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change form in marketing components to be a code embed #124

Conversation

jsladerman
Copy link
Contributor

to support hubspot forms
also changes landing pages to be a top-level route (closes PROD-2923)

@jsladerman jsladerman added the enhancement New feature or request label Nov 22, 2024
@jsladerman jsladerman requested a review from a team as a code owner November 22, 2024 22:21
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for plural-marketing ready!

Name Link
🔨 Latest commit 6f9cde4
🔍 Latest deploy log https://app.netlify.com/sites/plural-marketing/deploys/6744ce6fa7cf080008c12331
😎 Deploy Preview https://deploy-preview-124--plural-marketing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nickcernera nickcernera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but we need a URL redirect from https://plural.sh/kubernetes/demo-video to https://plural.sh/demo-video before merging

@jsladerman jsladerman merged commit 505d945 into main Nov 25, 2024
9 checks passed
@jsladerman jsladerman deleted the jake/prod-2915-change-form-in-marketing-components-to-be-a-code-embed branch November 25, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants